fix(docstore/awsdynamodb): ensure Next returns EOF when no more items #3406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405
Although I was unable to reproduce the panic, I added a preventive check for
awsdynamodb
here. This check returnsio.EOF
if there are no more items, which should prevent anindex out of range
panic whenNext
is called after it has already returnedEOF
once.I also added a test case to verify this behavior. The test repeatedly calls
Next
until it getsio.EOF
, then callsNext
again to ensure it still returnsio.EOF
.I also generated new replay files for
awsdynamodb
andgcpfirestore
.